Format UUID was set the same UUID into __id and UUID into document#737
Open
akitoshka wants to merge 1 commit into
Open
Format UUID was set the same UUID into __id and UUID into document#737akitoshka wants to merge 1 commit into
akitoshka wants to merge 1 commit into
Conversation
Contributor
|
This would destroy virtually everyone's existing setups. Someone please reject it. You also modified it in the DefaultDocumentFormatter which is used by more than just the elastic2 docmanager. For what it's worth, it isn't at all difficult to convert the hex string it's writing into whatever UUID format you need. IMO you should be doing that in your own code when reading from Elasticsearch, or maybe look into Elasticsearch computed fields. The hex form of the UUID is its true, raw form, totally agnostic to language and what I personally expect and prefer. It is not unexpected behaviour. |
Contributor
|
@akitoshka I don't quite understand the problem you are trying to solve here. Can you provide an example? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Format UUID was set the same for DBRef, UUID into_id and UUID into document.
Now there are two different approachs how the mongo-connector handles UUID.
The first approach looks like into elastic2_doc_manager, doc-manager sets UUID into Elasticsearch as is, using default str method (with '-' delimiters)
The second approach looks like as into formatter, mongo-connector get hex value (without delimiters).
So we have different behaviors if we work with _id or UUID into doc.
It is unexpected behavior so we have to fix this.